This page provides necessary guidelines for committers of Apache Lens.
New committers are encouraged to first read Apache's generic committer documentation:
<developer> <id>amareshwari</id> <email>email@example.com</email> <name>Amareshwari Sriramadasu</name> <timezone>+5.5</timezone> <roles> <role>PMC</role> <role>Committer</role> </roles> </developer>
Lens committers should, as often as possible, attempt to review patches submitted by others. Ideally every submitted patch will get reviewed by a committer within a few days. If a committer reviews a patch they've not authored, and believe it to be of sufficient quality, then they can commit the patch, otherwise the patch should be cancelled with a clear explanation for why it was rejected.
The list of submitted patches should be ordered by Updated timestamp - Lens patch available issues and Review board. Committers should scan the list from one which was updated earliest, looking for patches that they feel qualified to review and possibly commit.
Review guidelines are put up at review guidelines in contributer guide
The committers are allowed to commit their own patch only if the patch first receives a +1 vote from another committer.
Patches should be rejected which do not adhere to the guidelines above and code compliance guidelines in contributer guide. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review.
The commit repo is at https://git-wip-us.apache.org/repos/asf/lens.git When you commit a patch, please:
git config user.name "Amareshwari Sriramadasu" git config user.email "firstname.lastname@example.org"
git apply --check lens_patch.patch git apply lens_patch.patch
git commit -a --author "Amareshwari Sriramadasu <email@example.com>" -m "LENS-123 : Adds awesome feature to lens."
git revert HEAD~1..HEAD # To revert 1 commit. or, git revert a4r9593432 # To revert particular commit by commit id.
Once the patch is pushed to master, it can be cherry-picked and applied on other major version lines. If the patch is not applicable for master and only applicable to the release version, then above guide lines of review and commit needs to be followed with change of committing branch to be the release branch.
Fix version needs to include this release version as well.
Lens uses Apache SVN Pub-Sub system to maintain its website. The script tools/scripts/generate-site-public.sh can be used to generate the documentation, which has to be committed to website svn. Steps are as follows -